Skip to content

ci: retire GitHub-Action Slack notifier for new issues and PRs#9065

Merged
roger-zhangg merged 1 commit into
aws:developfrom
roger-zhangg:remove-slack-notifier-workflows
Jun 8, 2026
Merged

ci: retire GitHub-Action Slack notifier for new issues and PRs#9065
roger-zhangg merged 1 commit into
aws:developfrom
roger-zhangg:remove-slack-notifier-workflows

Conversation

@roger-zhangg

Copy link
Copy Markdown
Member

Summary

  • Delete .github/workflows/notify-slack.yml — the issue-opened slack notifier.
  • Remove the Send Slack Notification for External PR step from .github/workflows/pr-labeler.yml. The labeler still applies pr/internal vs pr/external + stage/needs-triage labels.

Why

The team's new GitHub-App-backed notifier (aws-sam-tooling-bot) is now operational and covers Slack pings for new issues and PRs across all team-owned repositories from a single backend. Keeping the per-repo rtCamp/action-slack-notify workflows on this repo causes duplicate posts and keeps SLACK_WEBHOOK_URL as a long-lived per-repo secret.

This change retires the per-repo path; no functional change to issue/PR triage labels.

Test plan

  • notify-slack.yml no longer present after the PR.
  • pr-labeler.yml retains both label-application paths (internal + external) and removes only the slack step.
  • After merge, confirm a new external PR still receives pr/external + stage/needs-triage labels via the labeler workflow run.
  • After merge, confirm Slack still receives the new-issue / new-PR pings via the App-backed notifier (separately verified in the team's notifier deploy).

Removes the rtCamp/action-slack-notify pings:

- Deletes .github/workflows/notify-slack.yml (issue-opened notifier).
- Drops the "Send Slack Notification for External PR" step from
  pr-labeler.yml; the labeler still applies pr/internal vs
  pr/external + stage/needs-triage labels as before.

Slack notifications for new aws-sam-cli issues and PRs are now sent by
the team's GitHub-App-backed notifier (aws-sam-tooling-bot), which
covers all of the team's owned repositories from a single backend
rather than per-repo workflows. Retiring the workflow-based path here
removes the duplicate posts and the long-lived SLACK_WEBHOOK_URL
secret dependency on this repo's behalf.
@roger-zhangg
roger-zhangg requested a review from a team as a code owner June 6, 2026 04:25
@roger-zhangg
roger-zhangg added this pull request to the merge queue Jun 8, 2026
Merged via the queue into aws:develop with commit 6c3b664 Jun 8, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants